Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: check empty registry mirror #761

Merged
merged 1 commit into from
Oct 27, 2021
Merged

chore: check empty registry mirror #761

merged 1 commit into from
Oct 27, 2021

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Oct 27, 2021 •
edited
Loading

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Fix #757 panic issue.

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner October 27, 2021 10:09
gaius-qi
gaius-qi approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yxxhero
yxxhero approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 6db54d8 into main Oct 27, 2021
@gaius-qi gaius-qi deleted the update-client branch October 27, 2021 11:48
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
@jim3ma @gaius-qi
chore: check empty registry mirror (#761)
a514681 
Signed-off-by: Jim Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@244372610 244372610 244372610 approved these changes

@gaius-qi gaius-qi gaius-qi approved these changes

@yxxhero yxxhero yxxhero approved these changes

@bergwolf bergwolf Awaiting requested review from bergwolf bergwolf is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@xujihui1985 xujihui1985 Awaiting requested review from xujihui1985 xujihui1985 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dfdaemon: runtime error: invalid memory address or nil pointer dereference
4 participants
@jim3ma @yxxhero @gaius-qi @244372610